[SVN] [Copern] Deleting pre-tamed pets after some time

[osd_daedalus]

Many tamers tame and release creatures. These creatures are detached from the spawner and serialized, thus making the world save time longer.

The proposal is to make pets, when tamed and released, to be automatically deleted after some time from the last release (psz suggests 1 week).

OSI: In OSI spawners work in a different way, and this report is meant for RunUO maintenance.

Would this need to add a new timer on creatures, or could we use an existant timer, like the one to let dead bonded pets disappear?

[Lucifall]

Probably would need a new timer. I believe 1 week is too long, though. I'd say 3 days, that should be enough for tamers to look for a lost pet and even re-tame them.

[osd_daedalus]

Hmmm...

the timer I was looking on is "OwnerAbandonTimer"... if it would be possible to use it, it would be better: another timer would need another thing to serialize, then the good effect of deleting creatures would be nullified...

[Lucifall]

Originally Posted by osd_daedalus

Hmmm...

the timer I was looking on is "OwnerAbandonTimer"... if it would be possible to use it, it would be better: another timer would need another thing to serialize, then the good effect of deleting creatures would be nullified...

Hmm, I ran into an idea now but I am not sure if it would work.

If the mob is controlled, the timer is the normal 8 hours and the mob abandons the owner by then.
if the mob is released and controlled is then set as false, the timer is now 3 days and it gets deleted by then.

[psz]

That is for Bonded Ghosts

(As I said in IRC)


THere are no timers currently to see how long since a pet was released (Though you can see previous owners)

And yes, 3 days was the timer I'd suggested in the end as well.

[Copern]

Here is something. Any current uncontrolled and unstabled creatures not belonging to a spawner are given a three day timer to delete. This is for ALL uncontrolled and spawnerless creatures upon first load! Let me know if this not desired.

Any time the controller is changed the timer is removed or restarted with 3 days. Releasing a pet will start the timer and taming it again will stop it. BaseEscortables and Summons are an exception to this (they have their own timers).

EDIT: Oh, there's a GM property to view the DeleteTimeLeft too.

[psz]

Don't think this will work: What if there are non-spawned mobiles used for events that last more than 3 days? Those would be removed as well.

Then there are monsters linked to controllers, monsters that are spawned by Champs, monsters spawned by the Brazier, monsters spawned by Linked Spawners, etc etc etc.


I think a better method would be "Is there a Previous Owner? If yes, then check how long since it's been released". No need to check for whether it's linked to a spawner (or anything else, for that matter). Once it's tamed, it's no longer linked to a spawner, afterall ;->

[Copern]

Originally Posted by psz

Don't think this will work: What if there are non-spawned mobiles used for events that last more than 3 days? Those would be removed as well.

Then there are monsters linked to controllers, monsters that are spawned by Champs, monsters spawned by the Brazier, monsters spawned by Linked Spawners, etc etc etc.


I think a better method would be "Is there a Previous Owner? If yes, then check how long since it's been released". No need to check for whether it's linked to a spawner (or anything else, for that matter). Once it's tamed, it's no longer linked to a spawner, afterall ;->

Alright, will do that tomorrow. Looks like there's already a Last Owner and abandon date too so that makes it easy. This was only for deserializing from a previous version by the way.

The only checks when the control master is set to start the timer is whether it's a summon, stabled, or whether it's a BaseEscortable. So the only thing that should cause creatures to be deleted post-update is if the creature is released.

[Copern]

Looks like the abandon time had to do with leaving a tamed pet alone. So there's no date/time recorded for when a pet was released. Anyway, on deserialization any creatures that previously had an owner and aren't currently controlled will be given a new 3 day timer or a timer based on the time left. This should leave alone anything that wasn't tamed. Only released/abandoned creatures should get the timer which is reset each time it is tamed and released.

[osd_daedalus]

To test this, I have created a fence outside boundaries of the TC headquarters (near the lava pit) and I have put in there:
- tamed and released horse, dog, giant beetle
- a untamed horse (by [add horse)

I wanted also to add an abandoned creature there: tamed, then the guy logs out and the pet loses loyalty until it becomes wild... but I realize in TC pets do autostable even if not bonded (or I haven't understood fully autostable).

For now, I can say all of pre-tamed creatures have a value DeleteTime that indicates about 3 days, while on the spawned horse the DeleteTime value is 0.