[SVN507] Missing sanitycheck in Spellhelper.cs

[osd_daedalus]

OSI: not validable

Demise/RunUO: check this one: http://www.runuo.com/forums/showthre...776#post827776

Do you believe it's a valid report and a valid fix?

note: I believe it can't be tested unless Demise/DemiseTC uses XMLAttachments.

[Kamron]

The fact that the damage function uses null as a valid parameter means that there needs to be checking. Relying on the fact that its not used, does not solve the potential problem.

This is valid.

[osd_daedalus]

This is the patch HellRazor, in the RunUO thread, proposes.

Since we don't use XMLAttachments, maybe the only things you want to see are if you can still leech correctly, and if some creatures like succubi can leech (but come on, they are both BaseCreatures!)

[psz]

Pretty sure both are (seperately) derived directly from BaseMobile.

[osd_daedalus]

in theory, the patch above would have broken something.

This one just checks that mobile "From" is not null. Cleaner and less harmful.

[osd_daedalus]

can we move this in Testing please?

[osd_daedalus]

mmm... you tested it Xavier/Athena/psz? Or is this in Ready for a mistake?

[Xavier]

yeah. and consulted with asayre to get some of these tiny, neglected patches out of the way, since it doesn't exactly take a brain surgeon to see they will work.

[osd_daedalus]

Originally Posted by Seer Xavier

yeah. and consulted with asayre to get some of these tiny, neglected patches out of the way, since it doesn't exactly take a brain surgeon to see they will work.

oh.. OK then

[osd_daedalus]

These are just sitting here, so...

Implemented in SVN 507.