Alchemy Bonus - Potions

[KraZ]

Reading UOGuide we have the following description:
As your skill improves you gain a Enhance Potions bonus of 10% for every 33 skill points achieved (30% at GM). This is on top of any bonus given by your equipment and hence not subject to your equipment cap (granting you a maximum benefit of 80%).

RunUO enhance potions bonus method, BasePotion.cs:

public static int EnhancePotions( Mobile m )
{
	int EP = AosAttributes.GetValue( m, AosAttribute.EnhancePotions );

	int cap = 50 + m.Skills.Alchemy.Fixed / 330 * 10;

	if ( Core.ML && EP > cap && m.AccessLevel <= AccessLevel.Player )
		EP = cap;

	return EP;
}

According to this method, RunUO fix the cap, only, but do not apply the bonus given by alchemy skill (you need to have in items 80% to reach this cap, instead of 50% items and 30% skill bonus.

This should be a solution to this thread:
http://uodemise.com/forum/showthread.php?t=143526

Please let me know if I got it all wrong (maybe UOGuide...). Attached code.

[Bama]

Originally Posted by KraZ

50% items and 30% skill bonus.

This is how it works on osi

The only way to reach the 80% cap is with the 30% skill bonus from being GM in alchemy

GM alchemy + 50% EP from items = 80% cap

[KraZ]

So, confirmed this RunUO error?
According to the method I posted RunUO increase the cap to 80% but you must reach in items (AosAttribute.EnhancePotions), except if there is another method or AosAttribute.EnhancePotions checks for skill bonus.

[El'ven]

+25% ring
+30% brace of alchemy , minor arti from paragon
+30% gm skill

should be 85% the most i think, isn't it ?

[KraZ]

Not really, there is a cap of 50% IN ITEMS, if you are GM alchemist an ADDITIONAL 30% should be applied (10% EP per 33% alchemy skill) = 80% EP cap

[Esqarrouth]

fixed..
enhance pot attribute in alchemy wasnt set. this causes alchemy to return ep attribute 50. if the item bonus passes 80 it starts to look at the skill. because it passes the cap.

int alchemyBonus = m.Skills.Alchemy.Fixed / 330 * 10;

			int EP = AosAttributes.GetValue( m,  AosAttribute.EnhancePotions ) + alchemyBonus;

			int cap = 50 + alchemyBonus;

			if ( Core.ML && EP > cap && m.AccessLevel <=  AccessLevel.Player )
				EP = cap;

[KraZ]

I've posted a fix... validation needed.

[Jacek.Kosiarz]

you can gain alchemy ep bonus from sphynx as well, so max should be 30gm + 30 alchemist brac + 25 ep ring + 25 ep sphynx = 110 ep